Bug#865223: acct: new init script is broken - DD Ping

Marcos Fouces marcos.fouces at gmail.com
Fri Jun 30 21:14:28 UTC 2017


Hello Lukas and team

I just reverted to the previous init.d script.

I set urgency value to high because the current version in testing is 
broken, hope that is ok.

Any available DD to review and upload it?

Greetings,

Marcos


El 29/06/17 a las 09:34, Lukas Schwaighofer escribió:
> Hi Marcos,
>
> On Thu, 29 Jun 2017 07:34:30 +0200
> Marcos Fouces <marcos.fouces at gmail.com> wrote:
>
>> I investigate more deeply this issue and i realized that i updated
>> start and stop functions for no purpose. There is not any improvement
>> with those change as the previous script performed well
>>
>> I suggest reverting to the previous version that you can see here:
>>
>> https://anonscm.debian.org/cgit/pkg-security/acct.git/tree/debian/acct.init.d?h=debian/6.5.5-2.1
> Looks reasonable, although the start_daemon shell function is probably
> doing more harm than good (possibly changes the exit code).  I
> would rather remove it.
>
> The check for exit code 38 (ENOSYS) seems correct and matches the
> acct(2) man page.  I don't know about exit code 16 (EBUSY) though, but
> keeping it shouldn't do harm.
>
>> Perhaps we could add status option but i think that anymore changes
>> are needed at this moment.
> There doesn't seem to be a way to find out if acct is enabled using the
> acct syscall or the accton binary.  Unless we have a way of asking the
> kernel whether it's enabled, I don't think we can implement the status
> option in a reliable way.
>
> Regards
> Lukas




More information about the Pkg-security-team mailing list