[Pkg-sql-ledger-discussion] New LedgerSMB Debian package, 1.3.18-1

[Raphael Hertzog]

Hi,

On Mon, 11 Jun 2012, Robert James Clay wrote:
>    I went ahead & submitted that Request for Sponsor bug because I
> didn't know how busy you might be at the moment.  If you can take care
> it, though, I'd appreciate it as you're already more familiar with it
> than someone else might be.

Uploaded. Some comments for the next time:

1/ I would not install the "css" and "templates" directories as examples.

   Because the postinst requires those files and this will break for
   people who are using dpkg's --path-exclude to drop /usr/share/doc/ (to
   save space). Put them in /usr/share/ledgersmb/. The "templates" symlink
   there is not useful anyway since apparently you patch the configuration
   to directly point to /var/lib/ledgersmb/templates. The same goes for
   the css symlink since you configured apache to look directly into
   /var/lib/ledgersmb/css/.

2/ I would not pollute the URL namespace with /lsmbcss. Why did you not
   use /ledgersmb/css/. That way you could have kept the default value
   for $cssdir. No ? (Somehow your TODO says that there are open problems
   related to this)

3/ The preinst code moving /etc/ledgersmb/templates to /var/lib/ledgersmb/
   should only be executed if we are upgrading from a version prior to
   1.3.18-1 and if /var/lib/ledgersmb/templates/ doesn't exist yet.

4/ debian/templates contains a type "expermental" instead of
   "experimental".

5/ Your TODO suggests to drop the UPGRADE file in favor of README.Debian.
   In theory, it's nice but in practice it's probably best to keep it
   around because you might forget to update the README.Debian and it's
   generally interesting to be able to read upstream recommendations too
   (after having read what the maintainer recommends in README.Debian).

> Note that this upload will resolve bug # 676639; that issue was fixed
> in upstream version 1.3.16. 

You should have put a "Closes: #676639" in the changelog then... why
didn't you do that?

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/