[Pkg-sql-ledger-discussion] Closing bugs in debian/changelog

[Robert James Clay]

On Wed, 2012-06-13 at 15:04 -0400, Raphael Hertzog wrote:

> Uploaded. Some comments for the next time:

> > Note that this upload will resolve bug # 676639; that issue was fixed
> > in upstream version 1.3.16. 
> 
> You should have put a "Closes: #676639" in the changelog then... why
> didn't you do that?

    Basically, a misunderstanding on my part of how the debian/changelog
gets processed for new uploads.

    The original bug was opened on 3 June, which was after I'd completed
and committed the packaging work for 1.3.17-1.  I realized that the
issue with the error from the LedgerSMB/Template/TXT.pm module during
the db conversion attempts was a specific and separate problem on the
4th.   I also realized then that it had been resolved with 1.3.16, which
I'd completed the packaging work for back on 8 May, and then cloned the
original bug to create one specific to that issue.

    What I now realize I could have done is either to update the
1.3.16-1 entry closing the bug and add an item to the 1.3.18 entry about
doing so.  And it still would have been found and closed with the 1.3.18
upload because the previous upload had actually been 1.3.15-2 and it
would have scanned the changes since then and closed the bug.  Or, since
the effective version for the closing of the bug would be 1.3.18-1 in
any case;  I could have had the actual closing in the 1.3.18-1 entry,
even mentioning that it was v1.3.16 that resolved it but without making
any changes to the 1.3.16-1 changelog entry itself.




Jame