Fwd: Re: unfreeze request - radiusclient-ng (0.5.5-1)

[Mark Purcell]

Jan,

Are you able to address Steve's comments below?

Thanks,
Mark

----------  Forwarded Message  ----------

Subject: Re: unfreeze request - radiusclient-ng (0.5.5-1)
Date: Saturday 10 February 2007 01:22
From: Steve Langasek <vorlon at debian.org>
To: Mark Purcell <msp at debian.org>
Cc: debian-release at lists.debian.org, radiusclient-ng at packages.debian.org

On Tue, Feb 06, 2007 at 11:04:36PM +0000, Mark Purcell wrote:
> This unfreeze request is purely an upstream bug fix for 64-bit
> architectures.

Well, no, it isn't.

> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/include/radiusclient-ng.h
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/include/radiusclient-ng.h ---
> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/include/radiusclient-ng.h    
> 2005-07-21 09:01:07.000000000 +0100 +++
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/include/radiusclient-ng.h    
> 2006-05-17 19:14:35.000000000 +0100

<snip>

This part is a 64-bit fix, sure.

> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/avpair.c
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/avpair.c ---
> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/avpair.c  2005-04-01
> 02:33:10.000000000 +0100 +++
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/avpair.c  2006-05-30
> 20:18:03.000000000 +0100

<snip>

This part is not.  It's probably a legitimate bugfix, but it's completely
undocumented, upstream or otherwise.  I'm not going to ok updates that
include undocumented changes I can't understand (and I've done enough RADIUS
to be wary of assuming the correctness of any patch based just on the local
diff context).

> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/sendserver.c
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/sendserver.c ---
> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/lib/sendserver.c      2005-07-21
> 09:01:07.000000000 +0100 +++
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/lib/sendserver.c      2006-07-05
> 01:27:54.000000000 +0100

<snip> Also doesn't appear to include any 64-bit fixes.  (the type change of
salen might be, but hard to say given that the effects of the change are
non-local and there's no real documentation in the changelog...)

> diff -Nru /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/src/radiusclient.c
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/src/radiusclient.c ---
> /tmp/Jk0DjtGJ17/radiusclient-ng-0.5.3/src/radiusclient.c    2005-03-01
> 14:58:44.000000000 +0000 +++
> /tmp/WWhXiWNXFX/radiusclient-ng-0.5.5/src/radiusclient.c    2006-04-04
> 21:52:04.000000000 +0100

<snip>

Another maybe, maybe-not 64-bit fix.

It's certainly RC to make sure any packages we're shipping on 64-bit archs
are actually usable there, so you're welcome to isolate the 64-bit fixes and
upload to testing-proposed-updates with just those changes.  Otherwise,
you can try to get upstream to give an explanation for each of these
changes and I'll take another look.

Thanks,
--
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon at debian.org                                   http://www.debian.org/

-------------------------------------------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/pkg-voip-maintainers/attachments/20070212/4f780918/attachment-0001.htm