[Po4a-devel]Re: [Po4a-commits] po4a/lib/Locale/Po4a TransTractor.pm,1.62,1.63

[Martin Quinson]

--1yeeQ81UyVL57Vl7
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 03, 2005 at 03:15:35PM +0200, Nicolas Fran=E7ois wrote:
> On Sun, Apr 03, 2005 at 01:27:25AM +0200, Denis Barbier wrote:
> > On Sat, Apr 02, 2005 at 09:57:15PM +0000, Nicolas FRAN??OIS wrote:
> > > Update of /cvsroot/po4a/po4a/lib/Locale/Po4a
> > > In directory haydn:/tmp/cvs-serv27444/lib/Locale/Po4a
> > >=20
> > > Modified Files:
> > > 	TransTractor.pm=20
> > > Log Message:
> > > If a comment is "0", it is evaluated to false and thus ignored.
> > > Use defined rather than the string evaluation.
> >=20
> > Martin has another solution for this problem, which is IMO better:
> > he checks if length($foo) > 0.
>=20
> I'm not sure it is needed here, because $options{'comment'}||"" was just
> used to make sure that $options{'comment'} is defined.

Yes, it is (should be) checked for length later, when producing a pot file.

Anyhow, the commited solution is not perfect, but I think it's good enough.

Mt.

--1yeeQ81UyVL57Vl7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCT/mjIiC/MeFF8zQRAkTUAKC4fVCvye/83DNO3QsWE3CDI7dCEACgqjPm
5TfRwGs5vgf6xHSmpw0NjdQ=
=qJA0
-----END PGP SIGNATURE-----

--1yeeQ81UyVL57Vl7--