[Po4a-devel]Re: [Po4a-commits] po4a/lib/Locale/Po4a TransTractor.pm,1.62,1.63

Nicolas François nicolas.francois@centraliens.net
Sun, 3 Apr 2005 17:22:07 +0200


On Sun, Apr 03, 2005 at 04:11:47PM +0200, Martin Quinson wrote:
> Yes, it is (should be) checked for length later, when producing a pot file.

Well... It should be.

The fact is that, even with the previous correction, a "0" comment is not
displayed in the PO, Po.pm needs some additional corrections.

I'm planning to update Po.pm

In the case of:
    output .= format_comment($self->{po}{$msgid}{'comment'},"")
        if $self->{po}{$msgid}{'comment'}
(This is just an example, many use the same construct)

Shall we just check for the length, or also check if the value is defined?

I advocate for both, which would permit to remove the test in
Transtractor.

-- 
Nekral