Bug#797259: musescore: CPUS=0 not handled properly

[Samuel Thibault]

Source: musescore
Version: 2.0.2+dfsg-1
Severity: important
Tags: patch
User: debian-hurd at lists.debian.org
Usertags: hurd

Hello,

The musescore build puts hurd-i386 buildds on their knees because it
runs make -j, thus filling the whole memory. Makefile is supposed to
have a guard against this, but it is bogus:

CPUS      = `grep -c processor /proc/cpuinfo`
# Avoid build errors when processor=0 (as in m68k)
ifeq ($(CPUS), 0)

is never true since expansion is not made by make here. $(shell should
be used instead, see proposed patch.

Samuel

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
<v> je viens d'inventer mutt version magritte :D
<y> ?
<v> dans mutt
<v> tape "cceci" return
-------------- next part --------------
--- Makefile.orig	2015-08-28 23:47:42.737370006 +0200
+++ Makefile	2015-08-28 23:47:52.889297905 +0200
@@ -19,7 +19,7 @@
 #=============================================================================
 
 REVISION  = `cat mscore/revision.h`
-CPUS      = `grep -c processor /proc/cpuinfo`
+CPUS      = $(shell grep -c processor /proc/cpuinfo)
 # Avoid build errors when processor=0 (as in m68k)
 ifeq ($(CPUS), 0)
   CPUS=1