Bug#765578: vlc: FTBFS on Hurd

Samuel Thibault sthibault at debian.org
Fri Aug 28 21:51:51 UTC 2015


Hello,

Gabriele Giacone, le Thu 16 Oct 2014 13:34:48 +0200, a écrit :
>    + Reintroduce hurd.patch, see #742183.

I have had a closer look, dropping _POSIX_CLOCK_SELECTION in glibc
should not break existing builds, so I'm fine with patching that in
glibc.

>    + Add hurd-path_max.patch, replacing unsupported PATH_MAX.

This however still needs to be applied for vlc to build on hurd-any, I
have attached it to this mail again.

There is also a small missing bit in zsh_completion.sh, see attached
patch (otherwise it just loops over trying to find libraries).

(Basically the whole kde-runtime is waiting for this to be fixed).

Samuel
-------------- next part --------------
Description: Replace PATH_MAX, unsupported on Hurd, with fixed size as in
 src/posix/filesystem.c
Author: Gabriele Giacone <1o5g4r8o at gmail.com>
--- a/modules/gui/skins2/src/theme_loader.cpp
+++ b/modules/gui/skins2/src/theme_loader.cpp
@@ -509,7 +509,10 @@ int tar_extract_all( TAR *t, char *prefi
     union tar_buffer buffer;
     int   len, err, getheader = 1, remaining = 0;
     FILE  *outfile = NULL;
-    char  fname[BLOCKSIZE + PATH_MAX];
+
+    long path_max = pathconf (".", _PC_PATH_MAX);
+    size_t maxsize = (path_max == -1 || path_max > 4096) ? 4096 : path_max;
+    char  fname[BLOCKSIZE + maxsize];
 
     while( 1 )
     {
-------------- next part --------------
--- zsh_completion.sh.orig	2015-08-28 21:34:50.000000000 +0000
+++ zsh_completion.sh	2015-08-28 21:35:10.000000000 +0000
@@ -13,7 +13,7 @@
     *cygwin*|*mingw*)
         SUFFIX=dll
     ;;
-    *linux*|*bsd*)
+    *linux*|*bsd*|*gnu*)
         SUFFIX=so
     ;;
     *)


More information about the pkg-multimedia-maintainers mailing list