[Pkg-netatalk-devel] More patches to flag as submitted upstream

Daniel Markstedt markstedt at gmail.com
Sun May 7 16:27:02 BST 2023


> I mean isolate patches and (not commit them to git as-such, but) put
> them below debian/patches and list them in debian/patches/series, test
> that all patches apply with "quilt push -a", and add those patch files +
> updated series file to git.

Got it! I'll figure this out. At least one of the CVE patches introduced a major
breakage. I'll try to consolidate the CVE patch with the breakage fix.

> Send an email to 740352-done at bugs.debian.org, with the additional header
> "Reply-To: 740352 at bugs.debian.org" and the very first line of content
> "Version: XXX" where XXX is the first Debian package version that
> contains the fixed code.

Cheers. Done!

BTW, I saw that the 3.1.15~ds1 package failed one of the smoke tests:

#     doesn't match '(?^:UAM search path:\t/usr/lib.*/netatalk//)'
# Looks like you failed 1 test of 26.

I believe the cause is https://github.com/Netatalk/netatalk/pull/311
The test should be updated to remove the extraneous trailing slash.
Do I have the permissions to modify the smoke tests already?

On Thu, May 4, 2023 at 1:31 PM Jonas Smedegaard <jonas at jones.dk> wrote:
>
> Quoting Daniel Markstedt (2023-05-04 22:07:03)
> > > Concretely, it would be great if you could look into cherry-picking the
> > > fixes for severe bugs (notably the CVEs) as patches for stable and
> > > oldstable.
> >
> > You mean cherry picking patches downstream into the Debian repo directly,
> > not waiting for a new Netatalk release to be tagged? I can sure do that.
> > And, since Ralph gave me full access to the upstream repo I can just as well
> > tag new Netatalk patch releases at any time. :)
>
> I mean isolate patches and (not commit them to git as-such, but) put
> them below debian/patches and list them in debian/patches/series, test
> that all patches apply with "quilt push -a", and add those patch files +
> updated series file to git.
>
> For more info, see https://wiki.debian.org/UsingQuilt
>
> Tagging new upstream releases is helpful for other distributions and for
> users compiling directly from upstream source, but for Debian stable and
> Debian oldstable it is better to use distinct patches to ensure minimal
> changes.
>
>
> > BTW, how do one go about closing out bugs in the Debian BTS?
> > #740352 was resolved with https://github.com/Netatalk/netatalk/pull/219
>
> Send an email to 740352-done at bugs.debian.org, with the additional header
> "Reply-To: 740352 at bugs.debian.org" and the very first line of content
> "Version: XXX" where XXX is the first Debian package version that
> contains the fixed code.
>
> For more info, see https://www.debian.org/Bugs/Developer#closing
>
>
>  - Jonas
>
> --
>  * Jonas Smedegaard - idealist & Internet-arkitekt
>  * Tlf.: +45 40843136  Website: http://dr.jones.dk/
>  * Sponsorship: https://ko-fi.com/drjones
>
>  [x] quote me freely  [ ] ask before reusing  [ ] keep private



More information about the pkg-netatalk-devel mailing list