[Pkg-netatalk-devel] More patches to flag as submitted upstream

[Jonas Smedegaard]

Quoting Daniel Markstedt (2023-05-07 17:27:02)
> > I mean isolate patches and (not commit them to git as-such, but) put
> > them below debian/patches and list them in debian/patches/series, test
> > that all patches apply with "quilt push -a", and add those patch files +
> > updated series file to git.
> 
> Got it! I'll figure this out. At least one of the CVE patches introduced a major
> breakage. I'll try to consolidate the CVE patch with the breakage fix.

Thanks!

> > Send an email to 740352-done at bugs.debian.org, with the additional header
> > "Reply-To: 740352 at bugs.debian.org" and the very first line of content
> > "Version: XXX" where XXX is the first Debian package version that
> > contains the fixed code.
> 
> Cheers. Done!

Perfect!


> BTW, I saw that the 3.1.15~ds1 package failed one of the smoke tests:
> 
> #     doesn't match '(?^:UAM search path:\t/usr/lib.*/netatalk//)'
> # Looks like you failed 1 test of 26.
> 
> I believe the cause is https://github.com/Netatalk/netatalk/pull/311
> The test should be updated to remove the extraneous trailing slash.

Right, that looks indeed like the fix needed for that test failure.


> Do I have the permissions to modify the smoke tests already?

Oh, seems we haven't provided you write access to the git repo at all
yet.

Git repo is hosted on an instance of Gitlab, where you need to create a
personal account and then request membership of the group here:
https://salsa.debian.org/netatalk-team/netatalk/-/project_members

But you should *not* edit upstream sourcecode directly.  Either isolate
a patch to be placed below debian/patches and auto-applied with quilt,
or (if that's imminent) wait for next upstream release and import that
using git-buildpackage.

I can isolate the patch, unless you want to try do it as an excercise.
Regardless, please request access to the git repo - or tell me if you
need help creating an account (which is _also_ an unusual process).

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private