Bug#883673: fix build with libcdio 1.0

[Matthias Klose]

On 06.12.2017 13:59, Dominic Hargreaves wrote:
> On Wed, Dec 06, 2017 at 11:46:31AM +0100, Matthias Klose wrote:
>> Package: src:libdevice-cdio-perl
>> Version: 0.4.0-2
>> Severity: serious
>> Tags: sid buster patch
>>
>> One driver is gone upstream.
>>
>> patch at
>> http://launchpadlibrarian.net/348274120/libdevice-cdio-perl_0.4.0-2build1_0.4.0-2ubuntu1.diff.gz
> 
> Hi Matthew,
> 
> I tried applying this patch (both to the Debian package and to upstream
> git ready for forwarding) but I get the following build failures on sid:
> 
> ./perlcdio_wrap.c: In function 'get_cdtext':
> ./perlcdio_wrap.c:2439:14: error: too many arguments to function 'cdio_get_cdtex
> t'
>      cdtext = cdio_get_cdtext (p_cdio, (track_t) track);
>               ^~~~~~~~~~~~~~~
> In file included from /usr/include/cdio/cdio.h:62:0,
>                  from ./perlcdio_wrap.c:1562:
> /usr/include/cdio/disc.h:77:13: note: declared here
>    cdtext_t *cdio_get_cdtext (CdIo_t *p_cdio);
>              ^~~~~~~~~~~~~~~
> ./perlcdio_wrap.c:2448:29: warning: passing argument 1 of 'cdtext_get_const' makes pointer from integer without a cast [-Wint-conversion]
>          if(cdtext_get_const(num,cdtext)) {
>                              ^~~
> In file included from /usr/include/cdio/cdio.h:59:0,
>                  from ./perlcdio_wrap.c:1562:
> /usr/include/cdio/cdtext.h:262:13: note: expected 'const cdtext_t * {aka const struct cdtext_s *}' but argument is of type 'int'
>  const char *cdtext_get_const (const cdtext_t *p_cdtext, cdtext_field_t field,
>              ^~~~~~~~~~~~~~~~
> ./perlcdio_wrap.c:2448:33: error: incompatible type for argument 2 of 'cdtext_get_const'
>          if(cdtext_get_const(num,cdtext)) {
>                                  ^~~~~~
> 
> [...]
> 
> (full log attached).
> 
> Do you have any suggestions about how to resolve this?

yes, fixed in libcdio-1.0.0-2