Bug#883673: fix build with libcdio 1.0

[Rocky Bernstein]

Don't know how this solves things, but  compiling locally there is another
problem with the *unpatched sources. *In the the 1.0.0 release I

*have*#define LIBCDIO_VERSION_NUM 10100

but this should be a number greater than 100. I am working on a
libcdio-1.1.0 release which will be out probably within a week or two that
addresses this problem.
It also addresses all of remaining memory leaks that I have been able to
find in the library code (and example programs and tests). So I kind of
consider it to be important.

I am also working on an update to Device::Cdio which removes long obsolete
code, and removes the no-longer-supported drivers (there are two, OS/2 and
BSDI, not one) and whatever else has changed in the last 5 or so years.


On Wed, Dec 6, 2017 at 8:06 AM, Matthias Klose <doko at debian.org> wrote:

> On 06.12.2017 13:59, Dominic Hargreaves wrote:
> > On Wed, Dec 06, 2017 at 11:46:31AM +0100, Matthias Klose wrote:
> >> Package: src:libdevice-cdio-perl
> >> Version: 0.4.0-2
> >> Severity: serious
> >> Tags: sid buster patch
> >>
> >> One driver is gone upstream.
> >>
> >> patch at
> >> http://launchpadlibrarian.net/348274120/libdevice-cdio-perl_
> 0.4.0-2build1_0.4.0-2ubuntu1.diff.gz
> >
> > Hi Matthew,
> >
> > I tried applying this patch (both to the Debian package and to upstream
> > git ready for forwarding) but I get the following build failures on sid:
> >
> > ./perlcdio_wrap.c: In function 'get_cdtext':
> > ./perlcdio_wrap.c:2439:14: error: too many arguments to function
> 'cdio_get_cdtex
> > t'
> >      cdtext = cdio_get_cdtext (p_cdio, (track_t) track);
> >               ^~~~~~~~~~~~~~~
> > In file included from /usr/include/cdio/cdio.h:62:0,
> >                  from ./perlcdio_wrap.c:1562:
> > /usr/include/cdio/disc.h:77:13: note: declared here
> >    cdtext_t *cdio_get_cdtext (CdIo_t *p_cdio);
> >              ^~~~~~~~~~~~~~~
> > ./perlcdio_wrap.c:2448:29: warning: passing argument 1 of
> 'cdtext_get_const' makes pointer from integer without a cast
> [-Wint-conversion]
> >          if(cdtext_get_const(num,cdtext)) {
> >                              ^~~
> > In file included from /usr/include/cdio/cdio.h:59:0,
> >                  from ./perlcdio_wrap.c:1562:
> > /usr/include/cdio/cdtext.h:262:13: note: expected 'const cdtext_t *
> {aka const struct cdtext_s *}' but argument is of type 'int'
> >  const char *cdtext_get_const (const cdtext_t *p_cdtext, cdtext_field_t
> field,
> >              ^~~~~~~~~~~~~~~~
> > ./perlcdio_wrap.c:2448:33: error: incompatible type for argument 2 of
> 'cdtext_get_const'
> >          if(cdtext_get_const(num,cdtext)) {
> >                                  ^~~~~~
> >
> > [...]
> >
> > (full log attached).
> >
> > Do you have any suggestions about how to resolve this?
>
> yes, fixed in libcdio-1.0.0-2
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20171206/de2a1e22/attachment.html>