[Pkg-security-team] Some problems with T50 packaging

[Marcos Fouces]

El 24/08/16 a las 02:00, Samuel Henrique escribió:
> Hi team and Marco
>
> I'm writing this because i saw some problems in the packaging of T50 
> and i would like to help and discuss about how to deal with then, by 
> the way, the current maintainer of T50 is Marco, and i would like to 
> ask to co-maintain T50 with you, if that's ok.

Yes, of course you can.

>
> debian/changelog: I believe somebody forgot to clear the Kali 
> leftovers from the changelog, is that a problem? If not, anyway, can 
> we clear then and left only the first entry related to the Debian 
> release? I beliebe it would be cleaner.

I left the credits for every kali packager because i use kali package as 
starting point. It is surely unfair not to give them credits.

>
> pristine-tar: The first tarball uploaded to this branch was the kali 
> one, from 5.4.1 (first debian shipped version is 5.6.4), is that a a 
> problem? Can we reset the pristine-tar branch with 5.6.4?
As i already said, i don't see the reason not to give them credits.


> Please also note that no upstream tags were made yet, so i believe it 
> would be less intrusive to reset pristine-tar.
> If somebody clones t50 packaging repo from our team and tries gbp 
> buildpackage, the build will fail because gbp will try to build the 
> kali version: "dpkg-deb: building package 't50' in 
> '../t50_5.4.1-rc1-1kali1_amd64.deb'."
Perhaps you need to configure gbp to use "debian/master" as the Debian 
branch. By default it uses the "master" branch that actually points to 
kali version.
>
> [serious]debian/patches/set-proper-compiler-flags.patch:
> The -march=native and -O3 flags were left intact, this is causing 
> FTBFS on 4 of the main architectures[1] and should be fixed asap.
Yes, it needs to be fixed. march=native is not ok. You can try to 
compile (or crosscompile) on other architectures and check of it is ok 
without this option. If so, it is trivial to patch upstream makefile.

Keep in mind that upstreams states clearly that t50 is only tested on 
amd64 and linux.

That for your help.

Cheers.
Marcos



> _______________________________________________
> Pkg-security-team mailing list
> Pkg-security-team at lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-security-team

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20160824/89f517a6/attachment.html>