[Pkg-security-team] Fwd: Websploit packaging

[Raphael Hertzog]

Hi,

On Thu, 25 Aug 2016, Marcos Fouces wrote:
> I just uploaded the package to the git repo. Please review it and tell me if
> there is something wrong, missing...

So I looked at the package.

- if you have ${python:Depends} (and you use dh_python2), then you don't
  need "python" in Depends
- I see you added many Recommends, can you document why they are needed?
  And some of them are clearly wrong:
  - ettercap-common: websploit uses "ettercap" so you need to recommend
    a package providing ettercap: "ettercap-text-only|ettercap"
  - nefilter (package does not exist): typo for netfilter? in which case
    you might want to depend on "iptables"

FTR I usually document Recommends/Suggests like this:

Recommends:
# used by modules/mitm.py
 dsniff,
# used by modules/arp_poisoner.py
 iptables,
...

In the debian directory, you package-prefixed files (websploit.install)
and files without prefix (docs). Please standardize on always using
package-prefixed files.

So rename debian/docs into debian/websploit.docs and debian/manpages into
debian/websploit.manpages. You can remove debian/dirs as the directories
listed there are automatically created by dh_install.

Apart from those details the package looks good.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/