[Qa-debsources] patch/copyright tracker status

Orestis Ioannou orestis at oioannou.com
Wed Dec 23 12:14:30 UTC 2015


On 12/23/2015 01:07 PM, Stefano Zacchiroli wrote:

> 
>> SPDX
>> I ve worked on this recently to fix the issues of dual license. I think
>> it is now good for review. PR#57
> 
> How dependent is this on the rest of the copyright tracker work? Given
> the bug was fixed, I think we can include this in the main copyright
> tracker PR, no?
> 

SPDX work on the fly right now. The issue is that for > medium size
packages it fails due to timeout of the request.
I think the speed would improve with the db since we won't need to parse
the c/p file again and retrive the license for each file.

>> Notable things missing:
>> - If we want to integrate this to the PTS then we would need a list of
>> all packages with machine-readable d/copyright files. To do that I
>> assume we need the DB
>> - avoid linking to non-existing folder or files
>> - refactoring stats templates to avoid c/p code..
> 
> Agreed. So this would probably need to wait until we have the updater.

Maybe for the copyright tracker buxy would agree to link to the
copyright tracker since all the files have a license even if it isn't
machine readable.
I could propose him a patch for this.

> 
> Note that I don't think there are any more blockers into giving the
> updater another try, given that IIRC we did fix the performance problems
> adding the needed foreign key constraints (does your memory agree with
> this?).
> 

Yes i seem to recall fixing a constraint that helped.
What i did in PR#52 is cache the parsed copyright file in order to
retrieve the license of foo.bar instead of parsing the d/copyright for
each file (yes i was stupid here !!)


>> - PTS integration. We need a list of all packages with supported patches
>> to do that
>> - Retrieve the checksum of the orig.tar.gz
>>
>> Blockers:
>>
>> - Everything works on the fly since there is not db for the tracker yet.
>> So we need a db schema and a plugin.
> 
> So to be precise these do not seem to be blocker for deploying the patch
> tracker on to sources.d.n. But they do are blockers for PTS
> integration. Right?
> 

PTS requires a file with all the packages that have patches so that it
only links to the patch tracker only for those packages and not for
everything. I don't know if we can do this without DB but yes that is
only something related to the PTS. the patch tracker works good on the
fly. Didn't observe any timeouts even for packages with many patches (linux)


> I'd be happy to discuss the DB schema/plugin for tracking within the DB
> the state of patches (better in a separate thread though).
> 

Ok i ll prepare something for this.

Cheers,

Orestis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/qa-debsources/attachments/20151223/e527e5c4/attachment.sig>


More information about the Qa-debsources mailing list